Code review comment for lp:~allenap/python-oops-datedir-repo/dont-depend-on-launchpadlib

Revision history for this message
Robert Collins (lifeless) wrote :

Hi, this seems to conflate three entirely different things:
 - it reformats some stuff (shrug)
 - it adds a totally new way to install the package, with a -tonne- of boilerplate (yuck)
 - it does a one-line change:
+ 'prune = oops_datedir_repo.prune:main [prune]'

The last thing seems to do its work on it's own - what is is the huge boilerplate for? Why does it need to be copied into the tree?

review: Needs Fixing

« Back to merge proposal