Merge lp:~allenap/maas/work-with-setuptools-in-zesty into lp:~maas-committers/maas/trunk

Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: no longer in the source branch.
Merged at revision: 5567
Proposed branch: lp:~allenap/maas/work-with-setuptools-in-zesty
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 32 lines (+6/-10)
2 files modified
MANIFEST.in (+5/-10)
setup.py (+1/-0)
To merge this branch: bzr merge lp:~allenap/maas/work-with-setuptools-in-zesty
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+311617@code.launchpad.net

Commit message

Fix MANIFEST.in to work with Zesty's apparently broken setuptools.

MANIFEST.in's mini-language has "graft" and "prune" commands. Previously these were interpreted as glob patterns but newer setuptools treat them as directory names.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

https://github.com/pypa/setuptools/pull/764 is implicated in the apparent regression.

Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm! Seems to be working on xenial and zesty. I've compared debian packages and no differences (other than not installing some tests).

Please backport this to lp:maas/2.1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'MANIFEST.in'
--- MANIFEST.in 2015-12-21 15:33:59 +0000
+++ MANIFEST.in 2016-11-23 14:49:19 +0000
@@ -1,11 +1,6 @@
1graft src/*/static1graft src/maasserver/static
2graft src/*/templates2graft src/maasserver/templates
3graft src/*/fixtures3graft src/metadataserver/fixtures
4graft src/*/specs4graft src/provisioningserver/templates
5graft src/provisioningserver/*
6graft src/metadataserver/commissioning
7include src/maasserver/migrations/south/django16_south_maas19.tar.gz5include src/maasserver/migrations/south/django16_south_maas19.tar.gz
8prune src/*/testing6include src/provisioningserver/drivers/power/*.xml
9prune src/*/tests
10prune src/maastesting
11prune src/provisioningserver/*/tests
127
=== modified file 'setup.py'
--- setup.py 2016-10-17 16:42:02 +0000
+++ setup.py 2016-11-23 14:49:19 +0000
@@ -89,6 +89,7 @@
89 "*.testing",89 "*.testing",
90 "*.tests",90 "*.tests",
91 "maastesting",91 "maastesting",
92 "maastesting.*",
92 ],93 ],
93 ),94 ),
94 package_dir={'': 'src'},95 package_dir={'': 'src'},