Merge lp:~allenap/maas/work-with-setuptools-in-zesty into lp:~maas-committers/maas/trunk

Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: no longer in the source branch.
Merged at revision: 5567
Proposed branch: lp:~allenap/maas/work-with-setuptools-in-zesty
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 32 lines (+6/-10)
2 files modified
MANIFEST.in (+5/-10)
setup.py (+1/-0)
To merge this branch: bzr merge lp:~allenap/maas/work-with-setuptools-in-zesty
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+311617@code.launchpad.net

Commit message

Fix MANIFEST.in to work with Zesty's apparently broken setuptools.

MANIFEST.in's mini-language has "graft" and "prune" commands. Previously these were interpreted as glob patterns but newer setuptools treat them as directory names.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

https://github.com/pypa/setuptools/pull/764 is implicated in the apparent regression.

Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm! Seems to be working on xenial and zesty. I've compared debian packages and no differences (other than not installing some tests).

Please backport this to lp:maas/2.1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MANIFEST.in'
2--- MANIFEST.in 2015-12-21 15:33:59 +0000
3+++ MANIFEST.in 2016-11-23 14:49:19 +0000
4@@ -1,11 +1,6 @@
5-graft src/*/static
6-graft src/*/templates
7-graft src/*/fixtures
8-graft src/*/specs
9-graft src/provisioningserver/*
10-graft src/metadataserver/commissioning
11+graft src/maasserver/static
12+graft src/maasserver/templates
13+graft src/metadataserver/fixtures
14+graft src/provisioningserver/templates
15 include src/maasserver/migrations/south/django16_south_maas19.tar.gz
16-prune src/*/testing
17-prune src/*/tests
18-prune src/maastesting
19-prune src/provisioningserver/*/tests
20+include src/provisioningserver/drivers/power/*.xml
21
22=== modified file 'setup.py'
23--- setup.py 2016-10-17 16:42:02 +0000
24+++ setup.py 2016-11-23 14:49:19 +0000
25@@ -89,6 +89,7 @@
26 "*.testing",
27 "*.tests",
28 "maastesting",
29+ "maastesting.*",
30 ],
31 ),
32 package_dir={'': 'src'},