Code review comment for lp:~allenap/maas/tftp-rebind-on-netif-change

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Are we using threads anywhere in pserv (other than spawning one after the HUP)? Signals don't play nice with threads but it may be moot if Twisted is DTRT.

Anyway, lovely change.

review: Approve

« Back to merge proposal