Merge lp:~allenap/maas/spurious-boot-source-test-failures into lp:~maas-committers/maas/trunk

Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: no longer in the source branch.
Merged at revision: 3585
Proposed branch: lp:~allenap/maas/spurious-boot-source-test-failures
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 21 lines (+4/-0)
1 file modified
src/maasserver/models/tests/test_bootsource.py (+4/-0)
To merge this branch: bzr merge lp:~allenap/maas/spurious-boot-source-test-failures
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Review via email: mp+251548@code.launchpad.net

Commit message

Skip test_calls_cache_boot_sources_on_create() because of possible isolation issues.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

Selfie, to unblock trunk.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/maasserver/models/tests/test_bootsource.py'
--- src/maasserver/models/tests/test_bootsource.py 2014-11-03 01:36:42 +0000
+++ src/maasserver/models/tests/test_bootsource.py 2015-03-03 04:08:22 +0000
@@ -15,6 +15,7 @@
15__all__ = []15__all__ = []
1616
17import os17import os
18from unittest import skip
1819
19from django.core.exceptions import ValidationError20from django.core.exceptions import ValidationError
20from maasserver.bootsources import cache_boot_sources21from maasserver.bootsources import cache_boot_sources
@@ -98,6 +99,9 @@
98 [],99 [],
99 boot_source_dict['selections'])100 boot_source_dict['selections'])
100101
102 # XXX: GavinPanella 2015-03-03 bug=1376317: This test is fragile, possibly
103 # due to isolation issues.
104 @skip("Possible isolation issues")
101 def test_calls_cache_boot_sources_on_create(self):105 def test_calls_cache_boot_sources_on_create(self):
102 mock_callLater = self.patch(reactor, 'callLater')106 mock_callLater = self.patch(reactor, 'callLater')
103 BootSource.objects.create(107 BootSource.objects.create(