Code review comment for lp:~allenap/maas/shared-to-per-tenant-storage

Revision history for this message
Gavin Panella (allenap) wrote :

> [7]
...
> I don't really see what the second test adds… since you're reloading the
> objects in the first test and you're getting what you expect, you can be sure
> the objects have been saved… ?

Good point. I was adding belts and braces where dungarees were being
worn :)

> [8]
...
> Similar remark here. Although I'd refactor the first test to reload the
> object before checking the owner, and I'd get rid of the second test.

Done.

« Back to merge proposal