Code review comment for lp:~allenap/maas/rpc-alt-cluster-rpc-fixture
Revision history for this message
| Julian Edwards (julian-edwards) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Monday 11 Aug 2014 08:27:22 you wrote:
> > I know it's easy to bikeshed over names, but they are important.
> >
> > We now have
> >
> > - ClusterRPCFixture
> > - RegionToCluster
> >
> > with no real indication of the difference from the names. Especially
> > since they are both Region-To-Cluster!
> >
> > Can I suggest this new one is MockClusterRPCF
> > "RegionToCluster" bit adds anything.
>
> The absence of direction in the name has confused a couple of people
> that I know of so far (not seriously confused, just a double-take), so
> I think the longer name has some value. ClusterRPCFixture is also
> deprecated now, and I'll try to remove it when I can. It's used in
> only one module so shouldn't be too much of a chore.
Can we at least get a Mock in there so we know it's been stubbed out?