Merge lp:~allenap/maas/repo-dumper-do-not-suppress-io-errors into lp:~maas-committers/maas/trunk
Proposed by
Gavin Panella
Status: | Merged |
---|---|
Approved by: | Gavin Panella |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5636 |
Proposed branch: | lp:~allenap/maas/repo-dumper-do-not-suppress-io-errors |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
47 lines (+13/-8) 2 files modified
src/provisioningserver/import_images/download_descriptions.py (+7/-0) src/provisioningserver/import_images/tests/test_download_descriptions.py (+6/-8) |
To merge this branch: | bzr merge lp:~allenap/maas/repo-dumper-do-not-suppress-io-errors |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brendan Donegan (community) | Needs Information | ||
Mike Pontillo (community) | Approve | ||
Review via email: mp+314524@code.launchpad.net |
Commit message
Don't suppress IOError in RepoDumper.sync.
This was allowing garbage to reach cache_boot_
To post a comment you must log in.
I'm not going to fully review this, but will say that CI tests point to it alleviating the issues mentioned above - notably we don't randomly end up with an empty boot source cache.