Merge lp:~allenap/maas/remove-ipmi-optimisation into lp:~maas-committers/maas/trunk
Proposed by
Gavin Panella
Status: | Merged |
---|---|
Approved by: | Raphaël Badin |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1467 |
Proposed branch: | lp:~allenap/maas/remove-ipmi-optimisation |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
55 lines (+6/-24) 2 files modified
src/provisioningserver/power/templates/ipmi.template (+6/-14) src/provisioningserver/power/tests/test_poweraction.py (+0/-10) |
To merge this branch: | bzr merge lp:~allenap/maas/remove-ipmi-optimisation |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Badin (community) | Approve | ||
Andres Rodriguez | Pending | ||
Review via email: mp+160146@code.launchpad.net |
Commit message
Formally revert to old IPMI power control behaviour: do not check the current state before issuing a power command.
To post a comment you must log in.
Looks good to me.
[0]
30 +# This script used to get the current power state, then only send a power
31 +# command if a change was needed. See bug 1171418 for an explanation.
It sounds a bit weird to only say what *used to* happen here. I think a short line explaining that we do not check the current power state and why would be welcome.