Code review comment for lp:~allenap/maas/remove-ip-from-amt

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Thursday 13 Feb 2014 10:11:09 you wrote:
> > Mostly fine but a question and a nit! Setting to approved though as I
> > don't want to block you.
> >
> > [1]
> > 49 + if 'mac_address' in kwargs:
> > 50 + kwargs['ip_address'] =
> > find_ip_via_arp(kwargs['mac_address'])
> >
> > If ip_address is not set, then the template will blow up. Why would
> > mac_address not be set in kwargs here?
>
> It's only in the power parameters for Etherwake and AMT.

Oh OK - the diff segment confused me more than it should have.

cheers.

« Back to merge proposal