Code review comment for lp:~allenap/maas/packaging.kill-all-the-configs-cluster

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Hi Gavin,

I tested this and overall it looks good:

1. Fresh install worked just fine.
2. Upgrade seemed to go ok, but it seems that it didn't migrate the config as expected. However, I think we can still merge this and look for other corner cases as I have not tested every single possible scenario and I'm thinking of making some packaging changes.

That being said, I think we can land and keep improving.

review: Approve

« Back to merge proposal