Code review comment for lp:~allenap/maas/notifications-creation

Revision history for this message
Gavin Panella (allenap) wrote :

> Looks good. Other than the one question I have. Which actually might
> allow you to remove that new dependency you added.

The new dependency is something we already pull in — python3-sphinx
depends on it, indirectly — so the net effect is zero. It'll only matter
if the dependencies of python3-sphinx change or if we stop depending on
python3-sphinx.

> We need to do some work to get the notifications to show on the none
> angular pages as well, since this branch removes notifications from
> those pages. Its not to hard to enable.

I'm interested to know how to do that.

Thanks!

« Back to merge proposal