I think we need to backport this to 2.1 too ?
On Mon, Nov 28, 2016 at 9:48 AM, Blake Rouse <email address hidden> wrote:
> Review: Approve > > Looks good. > > Diff comments: > > > > > === modified file 'services/regiond2/run' > > --- services/regiond2/run 2016-06-22 17:03:02 +0000 > > +++ services/regiond2/run 2016-11-08 16:20:29 +0000 > > @@ -33,4 +33,6 @@ > > > > # Exec the MAAS API and Web UI Server. > > script="$(readlink -f bin/twistd.region)" > > -exec "${script}" --nodaemon --pidfile="" maas-regiond > > +exec "${script}" \ > > + --logger=provisioningserver.logger.EventLogger \ > > This made it much easier to connect a custom logger. Less monkey patching > is always good. > > > + --nodaemon --pidfile="" maas-regiond > > > -- > https://code.launchpad.net/~allenap/maas/normalise- > logging--bug-1639182--yakkety/+merge/310330 > Your team MAAS Committers is subscribed to branch lp:maas. >
-- Andres Rodriguez Engineering Manager, MAAS Canonical USA, Inc.
« Back to merge proposal
I think we need to backport this to 2.1 too ?
On Mon, Nov 28, 2016 at 9:48 AM, Blake Rouse <email address hidden>
wrote:
> Review: Approve regiond2/ run' regiond2/ run 2016-06-22 17:03:02 +0000 regiond2/ run 2016-11-08 16:20:29 +0000 provisioningser ver.logger. EventLogger \ /code.launchpad .net/~allenap/ maas/normalise- +merge/ 310330
>
> Looks good.
>
> Diff comments:
>
> >
> > === modified file 'services/
> > --- services/
> > +++ services/
> > @@ -33,4 +33,6 @@
> >
> > # Exec the MAAS API and Web UI Server.
> > script="$(readlink -f bin/twistd.region)"
> > -exec "${script}" --nodaemon --pidfile="" maas-regiond
> > +exec "${script}" \
> > + --logger=
>
> This made it much easier to connect a custom logger. Less monkey patching
> is always good.
>
> > + --nodaemon --pidfile="" maas-regiond
>
>
> --
> https:/
> logging--bug-1639182--yakkety/
> Your team MAAS Committers is subscribed to branch lp:maas.
>
--
Andres Rodriguez
Engineering Manager, MAAS
Canonical USA, Inc.