Code review comment for lp:~allenap/maas/non-django-database-test

Revision history for this message
Gavin Panella (allenap) wrote :

> Looked through the code and I am still some what confused? What is
> legacy tests? I assume those must run as well when doing "make test"?
>
> Looking at the code it was hard to see the difference between a legacy
> test and a none legacy test. Also no documentation on when legacy
> should be used over a standard test type. Is this something where we
> need to do work on tests that use legacy to remove this new
> "test.region-legacy"?

I've done some work to whittle down the set of remaining legacy tests,
and it now stands at 71 tests. A legacy test is one that still needs to
run with the old Django test case and django_nose. 69 of those 71 need
it because they define `apps`, e.g.:

  class TestMAASModelForm(MAASLegacyTransactionServerTestCase):

      apps = ['maasserver.tests']

There will be a way around this, but I haven't figured it out yet.

The other 2 tests that I haven't figured out yet are:

  test_sends_message_for_config_windows_kms_host_insert
  test_sends_message_for_config_windows_kms_host_update

I haven't tried much to fix them, just put them aside for now.

The goal is definitely to eliminate these tests. For now, `make test`
will run bin/test.region.legacy so we won't be able to land broken
legacy tests.

« Back to merge proposal