Code review comment for lp:~allenap/maas/node-networking-api-get-mac-addresses-and-interfaces

Revision history for this message
Gavin Panella (allenap) wrote :

You're quite right, but it's Node.get_interfaces(). I've reimplemented it almost exactly! It has the recursive query too. Serves me right for wandering off on my own.

My original intent was to implement some of the new networking API where it's distinct from the old one. There's so much code in the models' modules, loose and on the managers and model classes themselves: I've long wanted to peel off some of the controller-like code and my temptation got the better of me today.

Part of my problem is that I've not been involved in this feature, during design or implementation, and I'm trying to pick it up in drips between other work. Separation was meant to make the thought process clearer.

Anyway, I'll rescind this and think again.

« Back to merge proposal