MAAS

Code review comment for lp:~allenap/maas/node-networking-api-get-mac-addresses-and-interfaces

  1. node-networking-api-get-mac-addresses-and-interfaces
  2. Merge into trunk
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Speaking of this InterfaceManager already has a get_interfaces_for_node. Which looks like it needs to be improved as your code gets all the nested interfaces. Makes me wonder if you would have placed this in the InterfaceManager you would have seen that it already exists.

« Back to merge proposal