MAAS

Code review comment for lp:~allenap/maas/make-web-access-logs-prettier

  1. make-web-access-logs-prettier
  2. Merge into trunk
Revision history for this message
Mike Pontillo (mpontillo) wrote :

I'm on the fence about this one. It looks like our previous logging was /almost/ in the "standard" HTTP log format[1], which has some utility: our current-format might make it easy to analyze the logs with any standard HTTP log analyzer. (ok, granted, maybe after a little grep/sed trickery.)

The best part of this change, to me, is the removal of the IPv4-mapped IPv6 address. That alone makes the log so much better already.

Thoughts?

[1]:
https://en.wikipedia.org/wiki/Common_Log_Format

review: Needs Information

« Back to merge proposal