Merge lp:~allenap/maas/compress-leases--bug-1387515 into lp:~maas-committers/maas/trunk
Proposed by
Gavin Panella
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Gavin Panella | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 3318 | ||||
Proposed branch: | lp:~allenap/maas/compress-leases--bug-1387515 | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Prerequisite: | lp:~allenap/maas/compressed-amp-list--bug-1387515 | ||||
Diff against target: |
20 lines (+2/-1) 1 file modified
src/provisioningserver/rpc/region.py (+2/-1) |
||||
To merge this branch: | bzr merge lp:~allenap/maas/compress-leases--bug-1387515 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | Approve | ||
Review via email: mp+240103@code.launchpad.net |
Commit message
Use CompressedAmpList in UpdateLeases.
Previously this call would fail with more than ~1450 leases. It will now work with up to ~3500 leases.
To post a comment you must log in.
Is it possible to backport this to 1.7 as OIL is being affected? Thanks
On Oct 30, 2014 7:34 AM, "Gavin Panella" <email address hidden>
wrote:
> Gavin Panella has proposed merging /bugs.launchpad .net/maas/ +bug/1387515 /code.launchpad .net/~allenap/ maas/compress- leases- -bug-1387515/ +merge/ 240103 /code.launchpad .net/~allenap/ maas/compress- leases- -bug-1387515/ +merge/ 240103 ngserver/ rpc/region. py' gserver/ rpc/region. py 2014-10-09 21:43:07 +0000 gserver/ rpc/region. py 2014-10-30 11:32:47 +0000 ver.rpc. arguments import (
> lp:~allenap/maas/compress-leases--bug-1387515 into lp:maas with
> lp:~allenap/maas/compressed-amp-list--bug-1387515 as a prerequisite.
>
> Commit message:
> Use CompressedAmpList in UpdateLeases.
>
> Previously this call would fail with more than ~1450 leases. It will now
> work with up to ~3500 leases.
>
> Requested reviews:
> MAAS Maintainers (maas-maintainers)
> Related bugs:
> Bug #1387515 in MAAS: "Failed to upload leases"
> https:/
>
> For more details, see:
>
> https:/
> --
>
> https:/
> You are subscribed to branch lp:maas.
>
> === modified file 'src/provisioni
> --- src/provisionin
> +++ src/provisionin
> @@ -43,6 +43,7 @@
> from provisioningser
> Bytes,
> Choice,
> + CompressedAmpList,
> ParsedURL,
> StructureAsJSON,
> )
> @@ -163,7 +164,7 @@
> arguments = [
> # The cluster UUID.
> (b"uuid", amp.Unicode()),
> - (b"mappings", amp.AmpList(
> + (b"mappings", CompressedAmpList(
> [(b"ip", amp.Unicode()),
> (b"mac", amp.Unicode())]))
> ]
>
>
>