Code review comment for lp:~allenap/maas/cluster-worker-logging

Revision history for this message
John A Meinel (jameinel) wrote :

So I think the specific change of 1294 is reasonable, but does it actually handle the case of 'start a new cluster-controller, point it at the region controller, and get some error logging while it is has not been accepted yet'?

I guess the biggest change is calling 'setup_logging_subsystem()' earlier, which should handle that.

So the other bit about getting rid of logging.task_logger and instead using a separate task_logger for each module. Why is that actually necessary?

Breaking it down:
1) Using CELERYD_LOG_FILE et al: Definitely good
2) Calling setup_logging_subsystem() earlier: Definitely good
3) Using separate task_loggers for each module: What is the purpose behind this? If you have a reason, good enough.

review: Approve

« Back to merge proposal