> Looks good.
>
> [0]
>
> 101 + setup_logging_subsystem(loglevel="INFO",
> logfile=get_maas_celery_log())
>
> I think you should make the log level a configuration option in the celery
> config file.
Yeah, I've discovered that this is already supported. I can remove the
arguments to setup_logging_subsystem and use CELERYD_LOG_LEVEL and
CELERYD_LOG_FILE instead. The latter means I can also get rid of
MAAS_CELERY_LOG.
Likewise, MAAS_CLUSTER_CELERY_DB can also be replaced with
CELERYBEAT_SCHEDULE_FILENAME.
Thanks for the review. I'll make these other changes next week before
I land this.
> Looks good. subsystem( loglevel= "INFO", get_maas_ celery_ log())
>
> [0]
>
> 101 + setup_logging_
> logfile=
>
> I think you should make the log level a configuration option in the celery
> config file.
Yeah, I've discovered that this is already supported. I can remove the subsystem and use CELERYD_LOG_LEVEL and
arguments to setup_logging_
CELERYD_LOG_FILE instead. The latter means I can also get rid of
MAAS_CELERY_LOG.
Likewise, MAAS_CLUSTER_ CELERY_ DB can also be replaced with SCHEDULE_ FILENAME.
CELERYBEAT_
Thanks for the review. I'll make these other changes next week before
I land this.