Code review comment for lp:~allenap/maas-test/use-system-packages

Revision history for this message
Raphaƫl Badin (rvb) wrote :

I agree with what Jeroen said. Which means that building an environment would now be a two-step process. Probably worth updating the README.txt file to explain (really quickly) how this works.

Regarding the changes to requirements.txt, I'm not sure we should manage this file manually like this. Especially now that it's only used for development dependencies, I think we should let pip manage it and generate it with "pip freeze > requirements.txt". Which means that adding a dev dependency would be as simple as:
pip install new-dev
pip freeze > requirements.txt

« Back to merge proposal