Code review comment for lp:~allenap/maas-test/onwards-python

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Very encouraging — let's try not to let this bit-rot! It'd be good to know that the API client will also work with python 3 before landing though. Maybe just put TODO comments in place for the changes that can't be done in a cross-dialect form?

The letters/ascii_letters change is compatible with Python 2, as are the list comprehensions to replace map() calls, so I'd land these no-brainer changes first as a separate branch.

« Back to merge proposal