Code review comment for lp:~allenap/maas-test/onwards-python

Revision history for this message
Gavin Panella (allenap) wrote :

This all went fairly smoothly. We don't have to land this now, if we're not sure we can see it through to the end (i.e. if porting the integration tests is going to be too yak-shavey), but it's interested to see nonetheless.

There were only a couple of classes of error in our Python 2 code: assuming map() returns a list, and a few comparisons between unicode and byte strings. This is quite encouraging, because they're easy things to spot and fix.

« Back to merge proposal