Code review comment for lp:~allenap/launchpad/ui-convert-filebug-3.0-bug-415263-search

Revision history for this message
Martin Albisetti (beuno) wrote :

> The form is being rendered by launchpad-form, which does not allow
> more than one widget per row. To get the button to display on the same
> row means either doing big work on launchpad-form, or bypassing it,
> which would lose us a lot and adds a big maintenance overhead.

I really hate these zope forms.

> Also, as Bjorn has just mentioned in our stand-up call, we very much
> need to pick up the pace of template conversions, so I'd like to leave
> these kinds of changes for the second round.
>
> Can we leave this for now, and perhaps schedule some work on
> launchpad-form?

Yes, go for it.

> For now, I've changed the "Report a bug" to an h2, which noodles
> suggested.

Great, thank you.

review: Approve (ui)

« Back to merge proposal