> Several tests broke, and one of them required quite a lot of work to
> fix. Basically, breadcrumbs were still being generated when viewing a
> bug that the user did not have permission to view. I've added a test to
> test_breadcrumbs and changed the adapter to cope with this scenario.
>
> I've attached an incremental diff.
>
> Thanks in advance.
Gavin.
I'm happy with the way you fixed breadcrumbs for private bugs, thanks for catching this problem before landing.
Regarding the previous diff, thanks for fixing print_location() and you are right that having 'UTC' repeated on each row would be bad ... the bug report is enough to sort this problem in the future.
> Several tests broke, and one of them required quite a lot of work to
> fix. Basically, breadcrumbs were still being generated when viewing a
> bug that the user did not have permission to view. I've added a test to
> test_breadcrumbs and changed the adapter to cope with this scenario.
>
> I've attached an incremental diff.
>
> Thanks in advance.
Gavin.
I'm happy with the way you fixed breadcrumbs for private bugs, thanks for catching this problem before landing.
Regarding the previous diff, thanks for fixing print_location() and you are right that having 'UTC' repeated on each row would be bad ... the bug report is enough to sort this problem in the future.
All good!