Code review comment for lp:~allenap/launchpad/subscribe-to-tag-bug-151129-5
Revision history for this message
| Edwin Grubbs (edwin-grubbs) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
Hi Gavin,
This is an impressive undertaking. Unfortunately, I'm having difficulty understanding the intent that led to some of the design decisions.
The BugSubscriptionSet seems to be intended just to eager load the subscribers and their ValidPersonCache value, if the list of subscriptions is iterated over, but to not make that extra query any sooner than necessary. I'm wondering why you wouldn't just use the pre_iter_hook as used in Bug._indexed_
Perhaps someone with more knowledge of the prerequisite branches would be better suited for reviewing this branch, but if not, I will be back at 15:00UTC, and I think talking on IRC will make this easier.
-Edwin