Code review comment for lp:~allenap/launchpad/subscribe-to-tag-bug-151129-2

Revision history for this message
Abel Deuring (adeuring) wrote :

A very nice branch and a very nice review!

Just one more nitpick: Gavin, could you add a doc string to BugFilterSetBiulder.__init__(), and especially :param ...: lines? What bugtask and level means is obvious to me, but I had to poke around a bit to figure out where join_codition comes from.

review: Approve (code)

« Back to merge proposal