Code review comment for lp:~allenap/launchpad/show-me-too-counts

Revision history for this message
Michael Nelson (michael.nelson) wrote :

> This branch does two things: shows the count of users affected by a
> bug (previously this has not been shown), and moves the "Does this bug
> affect you" line to above the bug task table.

Wow - that's really nice Gavin, especially the way you've ensure the language is very natural in every situation! (eg. "This bug affects you and 3 other people" versus "This bug affects 3 people, but not you")

We chatted about included the count for anon users:

<noodles775> allenap: wow, that feature is great!
<noodles775> allenap: I was wondering whether there was a decision behind *not* displaying the count for anon users?
<allenap> noodles775: No deliberate decision, just didn't actually think about it, doh.
<allenap> noodles775: I should probably add it!
<noodles775> allenap: that'd be great!
<allenap> noodles775: I'll make it simply say "This bug affects 27 people".
<noodles775> Perfect

review: Approve (ui)

« Back to merge proposal