Code review comment for lp:~allenap/launchpad/initseries-for-one-night-only-bug-793620

Thanks for the review!

> I think you're conflating things were they don't need to be. For
> +initseries, you only really care if the distroseries has been
> initialised, not if it is a derived series.

I have completely lost track of what this all means.

DistroSeries.is_derived_series checked if there are any DSPs, which
are, iirc, created by InitializeDistroSeries. As I understand it, they
are a marker that the distroseries has been initialized, that it is
now a derived distroseries. If initializing and deriving are very
different things that I'm conflating then I pity the users!

> The with featureflag(): section reads as a little messy -- I thought
> we had FeatureFixture for that which makes it easier?

I cargocult-n-pasted that. I've changed it to use FeatureFixture().

> Thank you for cleaning up the imports, but I don't think you can import DSDJ
> from lp.soyuz.model? Or if you can, why are you importing the whole module?

I didn't clean up the imports, utilities/format-imports took care of
that (by way of utilities/format-new-and-modified-imports). The
machine overlord has made its decision.