Launchpad itself

Code review comment for lp:~allenap/launchpad/initseries-for-one-night-only-bug-793620

  1. initseries-for-one-night-only-bug-793620
  2. Merge into devel
Revision history for this message
Steve Kowalik (stevenk) wrote :

I think you're conflating things were they don't need to be. For +initseries, you only really care if the distroseries has been initialised, not if it is a derived series.

The with featureflag(): section reads as a little messy -- I thought we had FeatureFixture for that which makes it easier?

Thank you for cleaning up the imports, but I don't think you can import DSDJ from lp.soyuz.model? Or if you can, why are you importing the whole module?

review: Needs Fixing (code)

« Back to merge proposal