Launchpad itself

Code review comment for lp:~allenap/launchpad/early-batching-bulk-methods-bug-509223

  1. early-batching-bulk-methods-bug-509223
  2. Merge into devel
Revision history for this message
Graham Binns (gmb) wrote :

<gmb> allenap, I think bulkSetStatus() is a little confusing, because it's called ...SetStatus() but it in fact mutates last_error_type. However, given that we should rename that at some point I'd settle for an XXX to the effect of "yes, this sounds confusing, it isn't"
 (and a bug)
<gmb> allenap, Other than that, the branch looks brilliant. r=me.

review: Approve (code)

« Back to merge proposal