Merge lp:~allenap/launchpad/dd-beta-icon-bug-827508 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Matthew Revell |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13854 |
Proposed branch: | lp:~allenap/launchpad/dd-beta-icon-bug-827508 |
Merge into: | lp:launchpad |
Diff against target: |
154 lines (+113/-0) 4 files modified
lib/canonical/launchpad/icing/style-3-0.css (+10/-0) lib/canonical/launchpad/images/src/beta.svg (+94/-0) lib/lp/registry/templates/distroseries-localdifferences.pt (+5/-0) lib/lp/registry/templates/distroseries-portlet-derivation.pt (+4/-0) |
To merge this branch: | bzr merge lp:~allenap/launchpad/dd-beta-icon-bug-827508 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Matthew Revell (community) | ui | Approve | |
Graham Binns (community) | code | Approve | |
Review via email: mp+72492@code.launchpad.net |
Commit message
[r=gmb]
Description of the change
Add a wretched beta icon to the +localpackagediffs page (and its
siblings) and to the DD portlet that appears on DistroSeries:
An earlier attempt used the existing beta.png, but it's fairly, and
didn't look right anywhere. See the non-#2 images at [1] for an idea.
I then tried putting a diagonal sash across the top left of the page
(in the case of +localpackagediffs) and a smaller sash across the top
left of the portlet. It looks good, but interfered with the content on
the page (not layout, things like being able to use links, or just
reading the text underneath) so I abandoned that.
Finally there's the current proposal, a simple short red bar with BETA
written within. It looks better than the existing beta icon, and also
works in paragraph context without looking like it's been left
behind. See the #2 images at [1] for example screenshots.
[1] http://
I have little experience as a designer so this has been frustrating,
slow going, and it's probably fairly crap. There's more that could be
done with this, like adding a help page, but someone else (or me next
week) can follow up on that. I see blood red mist when I think of the
time this branch has soaked up.
Thanks for taking the time to find the best way to communicate that this feature is in beta.
If Huw were here, we'd have sorted this fairly swiftly, I think. We need a re-usable recipe for indicating that something's in beta.
I agree that the red strip is better than the original beta icon. However, it looks a little lost on the full page.
Could we re-use the privacy ribbon from the Managing Disclosure project for the full page beta indicator? That would make it more clear that it's talking about the feature/page, rather than just one part of it, and it wouldn't interrupt the flow of the page.
The Teal squad originally allowed for dismissing the privacy ribbon, so that'd be a good way to avoid it being annoying.
I marking this "Needs information" because I want to know how long it would take to re-purpose the Teal squad's privacy ribbon. I think the portlet beta indicator is fine in the circumstances; we need Huw to re-work the design of the portlets generally.