Code review comment for lp:~allenap/launchpad/add-rabbit-service-bug-806160

> On Thu, Sep 15, 2011 at 5:07 AM, Gavin Panella <...> wrote:
>
> > Perhaps we could do something better:
> >
> > - config.push() could also write out the fragments its given to
> >  configs/$LPCONFIG/extra-${sequence}-${name}.conf
>
> We might want a special verb for this to avoid it happening my mistake
> on production servers.

By special verb, do you mean an alternative to .push() and .pop()? If
so, it might instead be worth having the special verb for pushing and
popping outside of dev/test; there are only a few places where these
methods are used outside of test/dev code:

  lib/lp/registry/scripts/distributionmirror_prober.py
  lib/canonical/launchpad/scripts/__init__.py
  lib/canonical/testing/layers.py
  lib/canonical/database/sqlbase.py

(In addition, .push() and .pop() could be disallowed - or warned about
- in non-dev/test environments.)

> Make clean probably would want to delete them all.

Agreed.

> The outer most test layer may want to zap them all as it comes up as
> well.

Agreed, thanks for thinking of that.

> Other than that this sounds good.

Tip top, thank you. Do you *need* me to do that before landing this
branch, or can I land this with a promise to sort out this new idea
asap? Red Squad are going to be working on longpoll as of now so even
a day or two's delay on this is going to affect that.