Code review comment for lp:~allenap/juju-core/makefile-stuff

Revision history for this message
Roger Peppe (rogpeppe) wrote :

https://codereview.appspot.com/12949047/diff/7001/Makefile
File Makefile (right):

https://codereview.appspot.com/12949047/diff/7001/Makefile#newcode64
Makefile:64: gofmt -w -l -s .
On 2013/08/28 11:54:23, allenap wrote:
> On 2013/08/28 06:23:17, jameinel wrote:
> > Given that "time make format" and "time make simplify" doen't seem
to differ,
> we
> > probably just want to always default to simplify.
> >
> > So:
> >
> > format: simplify
> >
> > simplify:
> > gofmt -w -l -s .

> Okay, I'll do that.

I'm not sure that we should always run simplify.
I think that format should mean just exactly gofmt;
"simplify" is a step further and should only be
done with a watchful eye, IMHO.

https://codereview.appspot.com/12949047/

« Back to merge proposal