Code review comment for lp:~allenap/juju-core/makefile-stuff

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-08-27 19:38, Gavin Panella wrote:
>> While I sort of agree, I don't find it harmful and it means
>> things "just work" for people who haven't finished configuring
>> them. Why do you feel they must be removed? (IOW, while I
>> slightly agree the net benefit of having them in there outweighs
>> the tiny downside of having a slightly larger ignore file, but
>> maybe I'm missing something.)
>
> This was a misguided attempt to make `bzr clean-tree --ignored`
> work consistently for everyone... but the patterns in
> ~/.bazaar/ignore are merged into the --ignored set, so my plan
> backfired, which was kind of obvious in retrospect. I've
> resurrected those patterns.

You could use "bzr clean-tree --detritus" ? It is the one I use most
often (to clean out things that bzr itself puts into the tree). For
good or bad bzr never did get the idea of "this is ignored because it
is garbage" separate "this is ignored because it is my precious
secrets that cannot be shared".

>
>>
>> The rest is fine to me though: +clean: + find . -name
>> '*.test' -print0 | xargs -r0 $(RM) -v
>>
>>
>> Should probably run 'go clean' somehow. Or at least delete 'go
>> build' output for various cmd programs.
>
> I didn't know of `go clean` before, and I've switched to it now.
>
> Thanks John!
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlIdlcAACgkQJdeBCYSNAAOAsgCeLtPdJC2dobi2t6zQC44huIiy
OgEAoKUtB5YwARSdL68/2wCbRr9gWDIF
=gdkE
-----END PGP SIGNATURE-----