Code review comment for lp:~allenap/juju-core/makefile-stuff

Revision history for this message
Gavin Panella (allenap) wrote :

> While I sort of agree, I don't find it harmful and it means things
> "just work" for people who haven't finished configuring them. Why do
> you feel they must be removed? (IOW, while I slightly agree the net
> benefit of having them in there outweighs the tiny downside of having
> a slightly larger ignore file, but maybe I'm missing something.)

This was a misguided attempt to make `bzr clean-tree --ignored` work
consistently for everyone... but the patterns in ~/.bazaar/ignore are
merged into the --ignored set, so my plan backfired, which was kind of
obvious in retrospect. I've resurrected those patterns.

>
> The rest is fine to me though:
> +clean:
> +       find . -name '*.test' -print0 | xargs -r0 $(RM) -v
>
>
> Should probably run 'go clean' somehow. Or at least delete 'go build'
> output for various cmd programs.

I didn't know of `go clean` before, and I've switched to it now.

Thanks John!

« Back to merge proposal