Code review comment for lp:~allenap/juju-core/azure-open-machine-ports

Revision history for this message
Raphaƫl Badin (rvb) wrote :

On 2013/07/30 23:16:12, allenap wrote:
> Please take a look.

[0]

Julian has a point, only one deployment should be present in the
service, and it has the same name as the service
('azInstance.ServiceName'). That will save one API call.

[1]

We've used a "tag" to indicate all the places in the code which rely on
the assumption that one juju instance = one service = one deployment so
that if people change that model, they will have a marker indicating all
the places where things must be changed. Would you mind adding this
"tag" in a comment somwhere: "(instance==service)"?

https://codereview.appspot.com/12102045/

« Back to merge proposal