LGTM
Given that we always map one role to one deployment to one service, is it strictly necessary to have that loop around deployments in OpenPorts()?
Also does juju's identifier for a protocol match that of Azure's? The doc for instance.Port does not say what "Protocol" is.
https://codereview.appspot.com/12102045/
« Back to merge proposal
LGTM
Given that we always map one role to one deployment to one service, is
it strictly necessary to have that loop around deployments in
OpenPorts()?
Also does juju's identifier for a protocol match that of Azure's? The
doc for instance.Port does not say what "Protocol" is.
https:/ /codereview. appspot. com/12102045/