Code review comment for lp:~allenap/gwacl/remove-role-endpoints-2

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 review: approve

Approved but I'm interested to know why you changed a couple of things!

> defer func() { Info("Removing role input endpoint...") - //
> FIXME: Something above - AddRoleEndpoints seems a prime suspect - -
> // causes Azure to do something asynchronously, which we must wait
> for - // before attempting this call, or it will blow up
> with a 409.

Was this fixed previously then? Or was it not a problem?

> -func newX509Response() *x509Response { - return &x509Response{
> - Body: make([]byte, 0), - } -} -
[snip]
> - response := newX509Response() + response :=
> &x509Response{} response.StatusCode = httpResponse.StatusCode
> response.Body, err = ioutil.ReadAll(httpResponse.Body) if err !=
> nil {
>

This is removing a make() on the Body - is that right/ok? Go still
leaves me wondering whether it has changed the semantics when you
assign to Body in the second-last line here ... :/

Cheers.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlHx4mAACgkQWhGlTF8G/HdkIwCgpzEEtzP+ZKpCNC68JEo9+a9t
1csAn1YEXFNDv2Dx/Iz3qoUbMJP2Jnc2
=IDOH
-----END PGP SIGNATURE-----