Code review comment for lp:~allanlesage/unity-scope-click/enable-coverage-reporting

Revision history for this message
dobey (dobey) wrote :

> Rodney, do lines 67-8 resolve your licensing concern?

Not really. The license is still different from the rest of the code we ship. And we cannot add the OpenSSL exception clause to this license. With the other file, which had no copyright/license info at all, gone from the branch, the licensing is at least something we are legally allowed to redistribute (and change) now. It just means shipping things under different licenses, in the same source, and having to deal with managing any necessary changes to these files across several projects, versus a central source for it.

> Lastly can you provide some instruction on packaging these CMake files? I.e.
> does a standard archive exist already for such, and how are they invoked,
> etc.?

On Ubuntu at least, cmake-data and qtbase5-dev include the majority of cmake modules. The Qt ones are shipped by Qt, and not cmake. I'm not sure why these haven't been included in upstream cmake already, but getting them accepted there would be one way to get them packaged centrally. Another option would be inside the gcovr/lcov packages, if the licensing allows for it. And another option would be to simply place them in their own package, cmake-coverage or something, which only ships these files.

« Back to merge proposal