Code review comment for lp:~allanlesage/unity-scope-click/enable-coverage-reporting

Revision history for this message
dobey (dobey) wrote :

As unity-scope-click is under the CLA, and is distributed as GPLv3+OpenSSL exception, I wonder if we can include this, given the cmake module being copy/pasted here is GPLv2+ without such an exception.

Is there any reason we cannot package the bits being added under cmake/ as a separate project/package in Ubuntu, which all our projects depend on? It will make updating for any changes much easier, and will not introduce such copyright/license conflicts in the distribution of the source.

Also, where is the ParseArguments.cmake module from? It has no copyright information at all in it, so I wonder if we are even allowed to redistribute it? Is there a particular reason that the standard cmake argument parsing module can't be used?

I'm basically OK with the changes that enable the feature, but I think we need to ship the actual cmake module separately as its own package.

« Back to merge proposal