Code review comment for lp:~allanlesage/uci-engine/coverage-extractor

Revision history for this message
Allan LeSage (allanlesage) wrote :

Francis, I've adapted your suggested changes with a couple of exceptions:

* Thomi explained the manual process of generating an OAuth1 key for NFSS to me--it doesn't sound like it's compatible with the automated deploy that you're explained via unit_config, as there are post-deploy steps. In any case I'd like to open a bug to discuss, and implement a later (likely the next) phase of our development.

* I've removed the NFSS deployment items from our juju_deploy template, meanwhile it seems unlikely that these would cause the deploy error you mention above as they're in a separate MP?

« Back to merge proposal