Code review comment for lp:~allanlesage/libcolumbus/enable-coverage-option

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Adding compiler flags via the target property is good.

There is the issue, though, that the code is lgpl3, which might mean we can't put it in our projects without a CLA. In addition it prevents submitting this upstream as CMake is BSD licensed.

review: Needs Information

« Back to merge proposal