Code review comment for lp:~allanlesage/kubuntu-packaging/qt3d-enable-tests

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Thanks for your work here. We usually prefer when:

- tests are built in build target, not in override_dh_auto_test (i.e. use QT_BUILD_PARTS+=tests);
- you actually use dh_auto_test (i.e. 'dh_auto_test -- -C tests/auto/' is a much simplier command than yours);
- and if dh_auto_test for some reason doesn't work for you, make sure DEB_BUILD_OPTIONS=nocheck is honored.

Check qtsvg-opensource-src for an example of a good implementation.

review: Needs Fixing

« Back to merge proposal