cupstream2distro Configuration

Merge lp:~allanlesage/cupstream2distro-config/enable-webcred-coverage into lp:cupstream2distro-config

  1. enable-webcred-coverage
  2. Merge into trunk
Proposed by Allan LeSage
Status: Merged
Approved by: Francis Ginther
Approved revision: 1126
Merged at revision: 1135
Proposed branch: lp:~allanlesage/cupstream2distro-config/enable-webcred-coverage
Merge into: lp:cupstream2distro-config
Diff against target: 117 lines (+52/-5)
2 files modified
stacks/head/settings.cfg (+9/-3)
stacks/head/webcred.cfg (+43/-2)
To merge this branch: bzr merge lp:~allanlesage/cupstream2distro-config/enable-webcred-coverage
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Francis Ginther Approve
Review via email: mp+219606@code.launchpad.net

Commit message

Enable coverage for webcred.

Description of the change

Enable coverage for webcred, working from a list that fginther gave me, others in that list need a bit of love before being added; we can either add those (account-plugins, gnome-control-center-signon, libaccounts-glib) to this MP or treat separately.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1124
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~allanlesage/cupstream2distro-config/enable-webcred-coverage/+merge/219606/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-ci/694/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-utopic-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-utopic-i386-ci/5

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/cupstream2distro-config-ci/694/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

All of the hooks lines need H05set_package_version. I think I caught them all in the inline comments below.

Also all projects which are having coverage.xml added to the archived artifacts need to have the following added:
    configurations:
      utopic-armhf:
        archive_artifacts: '**/output/*deb, **/coverage.xml'

This is needed because the ci_default block at the top of the stack is set to only collect the deb files. When adding coverage, this needs to collect the deb files and the xml files.

review: Needs Fixing
Revision history for this message
Francis Ginther (fginther) wrote :

In case I forgot the inline comments.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1125
http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-ci/704/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-utopic-amd64-ci/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-utopic-i386-ci/15

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/cupstream2distro-config-ci/704/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Looks good, thanks for the update.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
Unapproved changes made after approval.
http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-autolanding/713/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-utopic-amd64-autolanding/14
    SUCCESS: http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-utopic-i386-autolanding/14

review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Must have hit an approve race, let's try again.

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'stacks/head/settings.cfg'
--- stacks/head/settings.cfg 2014-06-04 18:53:57 +0000
+++ stacks/head/settings.cfg 2014-06-05 14:53:19 +0000
@@ -38,9 +38,15 @@
38 publish_coverage: '**/results/coverage.xml'38 publish_coverage: '**/results/coverage.xml'
39 publish_junit: '**/*test*.xml'39 publish_junit: '**/*test*.xml'
40 ubuntu-system-settings-online-accounts:40 ubuntu-system-settings-online-accounts:
41 daily_release: False41 daily_release: False
42 autolanding_template: False42 autolanding_template: False
43 use_stack_ppa: False43 use_stack_ppa: False
44 hooks: H05set_package_version H10enable_coverage D10install_lcov B09qmakecoverage D09add_ppa~gcovr-team~ppa D10install_gcovr B10gcovr_run C09copy_results
45 archive_artifacts: '**/coverage.xml'
46 publish_coverage: '**/coverage.xml'
47 configurations:
48 utopic-armhf:
49 archive_artifacts: '**/output/*deb, **/coverage.xml'
44 gsettings-qt:50 gsettings-qt:
45 daily_release: False51 daily_release: False
46 autolanding_template: False52 autolanding_template: False
4753
=== modified file 'stacks/head/webcred.cfg'
--- stacks/head/webcred.cfg 2014-06-04 18:53:57 +0000
+++ stacks/head/webcred.cfg 2014-06-05 14:53:19 +0000
@@ -29,11 +29,22 @@
29 daily_release: False29 daily_release: False
30 autolanding_template: False30 autolanding_template: False
31 use_stack_ppa: False31 use_stack_ppa: False
32 hooks: H05set_package_version32 hooks: H05set_package_version H10enable_coverage D10install_lcov B09qmakecoverage D09add_ppa~gcovr-team~ppa D10install_gcovr B10gcovr_run C09copy_results
33 archive_artifacts: '**/coverage.xml'
34 publish_coverage: '**/coverage.xml'
35 configurations:
36 utopic-armhf:
37 archive_artifacts: '**/output/*deb, **/coverage.xml'
33 gnome-control-center-signon:38 gnome-control-center-signon:
34 daily_release: False39 daily_release: False
35 autolanding_template: False40 autolanding_template: False
36 use_stack_ppa: False41 use_stack_ppa: False
42 hooks: H05set_package_version H10enable_coverage D10install_lcov B09qmakecoverage D09add_ppa~gcovr-team~ppa D10install_gcovr B10gcovr_run C09copy_results
43 archive_artifacts: '**/coverage.xml'
44 publish_coverage: '**/coverage.xml'
45 configurations:
46 utopic-armhf:
47 archive_artifacts: '**/output/*deb, **/coverage.xml'
37 libaccounts-glib:48 libaccounts-glib:
38 daily_release: False49 daily_release: False
39 autolanding_template: False50 autolanding_template: False
@@ -45,6 +56,12 @@
45 daily_release: False56 daily_release: False
46 autolanding_template: False57 autolanding_template: False
47 use_stack_ppa: False58 use_stack_ppa: False
59 hooks: H05set_package_version H10enable_coverage D10install_lcov B09qmakecoverage D09add_ppa~gcovr-team~ppa D10install_gcovr B10gcovr_run C09copy_results
60 archive_artifacts: '**/coverage.xml'
61 publish_coverage: '**/coverage.xml'
62 configurations:
63 utopic-armhf:
64 archive_artifacts: '**/output/*deb, **/coverage.xml'
48 libsignon-glib:65 libsignon-glib:
49 daily_release: False66 daily_release: False
50 autolanding_template: False67 autolanding_template: False
@@ -53,11 +70,22 @@
53 daily_release: False70 daily_release: False
54 autolanding_template: False71 autolanding_template: False
55 use_stack_ppa: False72 use_stack_ppa: False
56 hooks: H05set_package_version H40native_hack.py73 hooks: H05set_package_version H40native_hack.py H10enable_coverage D10install_lcov B09qmakecoverage D09add_ppa~gcovr-team~ppa D10install_gcovr B10gcovr_run C09copy_results
74 archive_artifacts: '**/coverage.xml'
75 publish_coverage: '**/coverage.xml'
76 configurations:
77 utopic-armhf:
78 archive_artifacts: '**/output/*deb, **/coverage.xml'
57 signon-apparmor-extension:79 signon-apparmor-extension:
58 daily_release: False80 daily_release: False
59 autolanding_template: False81 autolanding_template: False
60 use_stack_ppa: False82 use_stack_ppa: False
83 hooks: H05set_package_version H10enable_coverage D10install_lcov B09qmakecoverage D09add_ppa~gcovr-team~ppa D10install_gcovr B10gcovr_run C09copy_results
84 archive_artifacts: '**/coverage.xml'
85 publish_coverage: '**/coverage.xml'
86 configurations:
87 utopic-armhf:
88 archive_artifacts: '**/output/*deb, **/coverage.xml'
61 signon-keyring-extension:89 signon-keyring-extension:
62 daily_release: False90 daily_release: False
63 autolanding_template: False91 autolanding_template: False
@@ -65,16 +93,29 @@
65 hooks: H05set_package_version H10enable_coverage D10install_lcov B09qmakecoverage D09add_ppa~gcovr-team~ppa D10install_gcovr B10gcovr_run C09copy_results93 hooks: H05set_package_version H10enable_coverage D10install_lcov B09qmakecoverage D09add_ppa~gcovr-team~ppa D10install_gcovr B10gcovr_run C09copy_results
66 archive_artifacts: '**/coverage.xml'94 archive_artifacts: '**/coverage.xml'
67 publish_coverage: '**/coverage.xml'95 publish_coverage: '**/coverage.xml'
96 configurations:
97 utopic-armhf:
98 archive_artifacts: '**/output/*deb, **/coverage.xml'
68 signon-plugin-oauth2:99 signon-plugin-oauth2:
69 daily_release: False100 daily_release: False
70 autolanding_template: False101 autolanding_template: False
71 use_stack_ppa: False102 use_stack_ppa: False
72 hooks: H05set_package_version B09qmakecoverage D09add_ppa~gcovr-team~ppa D10install_gcovr B10gcovr_run H10enable_coverage H40native_hack.py D10install_lcov C09copy_results103 hooks: H05set_package_version B09qmakecoverage D09add_ppa~gcovr-team~ppa D10install_gcovr B10gcovr_run H10enable_coverage H40native_hack.py D10install_lcov C09copy_results
104 archive_artifacts: '**/coverage.xml'
105 publish_coverage: '**/coverage.xml'
106 configurations:
107 utopic-armhf:
108 archive_artifacts: '**/output/*deb, **/coverage.xml'
73 signon-ui:109 signon-ui:
74 daily_release: False110 daily_release: False
75 autolanding_template: False111 autolanding_template: False
76 use_stack_ppa: False112 use_stack_ppa: False
77 hooks: H05set_package_version H10enable_coverage D09add_ppa~gcovr-team~ppa D10install_gcovr D10install_lcov B09qmakecoverage C09copy_results113 hooks: H05set_package_version H10enable_coverage D09add_ppa~gcovr-team~ppa D10install_gcovr D10install_lcov B09qmakecoverage C09copy_results
114 archive_artifacts: '**/coverage.xml'
115 publish_coverage: '**/coverage.xml'
116 configurations:
117 utopic-armhf:
118 archive_artifacts: '**/output/*deb, **/coverage.xml'
78 ubuntuone-client-data:119 ubuntuone-client-data:
79 daily_release: False120 daily_release: False
80 autolanding_template: False121 autolanding_template: False

Subscribers

People subscribed via source and target branches

to all changes: