Code review comment for lp:~allanlesage/address-book-app/abook_navigation_favorites

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

On an LXC container with all updates applied, I get the following error, maybe because a service is not running:
0:45:55.249 INFO globals:57 - ************************************************************
10:45:55.249 INFO globals:58 - Starting test address_book_app.tests.test_favorites.TestFavorite.test_save_multiple_favorites
10:45:55.249 ERROR content:49 - Could not add content object 'None' due to IO Error: [Errno 13] Permission denied: '/var/log/syslog'
10:45:55.333 INFO _launcher:152 - Launching process: ['/usr/bin/address-book-app', '-testability', '--desktop_file_hint=/usr/share/applications/address-book-app.desktop']
10:45:56.409 DEBUG dbus:431 - Selecting objects of type MainWindow with attributes: {}
10:45:56.630 DEBUG dbus:431 - Selecting objects of type MainWindow with attributes: {}
10:45:56.645 DEBUG dbus:431 - Selecting objects of type ContactListPage with attributes: {'objectName': 'contactListPage'}
10:45:56.679 DEBUG dbus:431 - Selecting objects of type Label with attributes: {'text': 'Beth Whittard'}
10:45:56.704 ERROR contact_list_page:114 - Contact Beth Whittard not found.
10:45:56.720 INFO _launcher:340 - waiting for process to exit.
10:45:56.720 INFO _launcher:266 - Killing process 9593
}}}

Traceback (most recent call last):
  File "/home/ubuntu/Touch/GapCoverage/src/abook_navigation_favorites/tests/autopilot/address_book_app/tests/test_favorites.py", line 70, in test_save_multiple_favorites
    list_page.click_contact_by_name('Beth Whittard')
  File "/home/ubuntu/Touch/GapCoverage/src/abook_navigation_favorites/tests/autopilot/address_book_app/emulators/contact_list_page.py", line 127, in click_contact_by_name
    contact_name, parent_delegate_type)
  File "/home/ubuntu/Touch/GapCoverage/src/abook_navigation_favorites/tests/autopilot/address_book_app/emulators/contact_list_page.py", line 112, in get_contact_by_name
    raise StateNotFoundError('Label')
StateNotFoundError: State not found for class 'Label'.

======================================

About jinja2, I'd remove the dependency on jinja2 because it forces the installation of a new package on the device and the logic is simple enough to be implemented with str.format() and standard string functions.

======================================

Data sample: Would it be possible to pre-load vcards instead of creating/updating contacts. contacts.db backup/restore and services restart adds a lot of complexity to the test and also requires an additional dependency on psutil.

review: Needs Fixing

« Back to merge proposal