Code review comment for ~alkisg/ubuntu/+source/ipxe:lp1811496

Revision history for this message
Alkis Georgopoulos (alkisg) wrote :

Hi, regarding "EOF", I imitated what the other scripts in /etc/grub.d where doing for two reasons:
One is for code consistency, and the second is that I think they're doing that to avoid an empty line if ${entry} is completely empty. It's possible to avoid empty lines while using variables in HEREDOCs, but it's less readable.

The shellcheck error about the unquoted ${GRUB_DEVICE_BOOT} isn't part of the diff, we didn't touch it...

Thanks!

« Back to merge proposal