Merge lp:~alisonken1/openlp/windows_lo_fix into lp:openlp
Status: | Merged |
---|---|
Merged at revision: | 2825 |
Proposed branch: | lp:~alisonken1/openlp/windows_lo_fix |
Merge into: | lp:openlp |
Diff against target: |
128 lines (+91/-2) 2 files modified
openlp/core/common/__init__.py (+13/-2) tests/functional/openlp_core/common/test_network_interfaces.py (+78/-0) |
To merge this branch: | bzr merge lp:~alisonken1/openlp/windows_lo_fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tomas Groth | Approve | ||
Tim Bentley | Approve | ||
Review via email: mp+352333@code.launchpad.net |
Commit message
Fix windows not naming localhost interface to lo
Description of the change
- Rename localhost to lo if found in iterfaces
- Add check for lo not in interface list before trying to remove lo
- Add extra log debug info
- Add test to check for get_local_ip4() returning no interfaces
-------
lp:~alisonken1/openlp/windows_lo_fix (revision 2825)
https:/
https:/
https:/
https:/
https:/
https:/
https:/
https:/
Looks Ok to me.