Code review comment for lp:~alikrubin75/undrop-for-innodb/undrop-for-innodb

Revision history for this message
Aleksandr Kuzminsky (akuzminsky) wrote :

See inline.
In principle, it's possible a deleted record is still a member of the records list in a page. If so, then the record will be recovered.
Sometimes InnoDB excludes deleted records form the list. I don't know what it depends on, just have seen that before.
So, if check_page() returns OK and the deleted record isn't part of the list it will be silently ignored. If check_page() returns Not OK then c_parser will produce junk records which can be filtered out with c_parser filters. This is better than silently ignoring the deleted records.

review: Needs Fixing

« Back to merge proposal