Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/pulseaudio:dbus-support into ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master

Proposed by Alfonso Sanchez-Beato
Status: Merged
Merged at revision: ba7c14170389c7f5cfef072ae018f55171675295
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/pulseaudio:dbus-support
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master
Diff against target: 57 lines (+11/-14)
1 file modified
snapcraft.yaml (+11/-14)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Needs Fixing
Review via email: mp+387586@code.launchpad.net

Commit message

Add additional plugs to support ALSA fully
Enable dbus and add bluez plug
Move to audio-playback, audio-record interfaces instead of pulseaudio

Description of the change

Add additional plugs to support ALSA fully
Enable dbus and add bluez plug
Move to audio-playback, audio-record interfaces instead of pulseaudio

To post a comment you must log in.
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

This snapd MP needs to be merged & released before merging this one:

https://github.com/snapcore/snapd/pull/9031

Also, auto-connect for the new interfaces would need to be set-up in the brand store.

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: afd9a476ab34eacb450ded5df6e9b95d9a4b00ab

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1348/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: 47d61045c73d554f9123fa289a1d2e1479e2ee63

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1349/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/snapcraft.yaml b/snapcraft.yaml
index 34e50a4..35db317 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -16,33 +16,31 @@ apps:
16 pulseaudio:16 pulseaudio:
17 command: bin/pulseaudio17 command: bin/pulseaudio
18 daemon: simple18 daemon: simple
19 plugs: [network, network-bind]19 plugs: [network, network-bind, bluez, hardware-observe, alsa]
20 slots: [service]20 slots: [service, audio-playback, audio-record]
21 pactl:21 pactl:
22 command: bin/client-wrapper usr/bin/pactl22 command: bin/client-wrapper usr/bin/pactl
23 plugs: [client, network]23 plugs: [playback, record, network]
24 # NOTE: This is deprecated with snapd 2.25 but needs to stay to
25 # guarantee all clients are updated correctly.
26 paplay:24 paplay:
27 command: bin/client-wrapper usr/bin/paplay25 command: bin/client-wrapper usr/bin/paplay
28 plugs: [client, home, network]26 plugs: [playback, home, network]
29 # NOTE: This is deprecated with snapd 2.25 but needs to stay to
30 # guarantee all clients are updated correctly.
31 parec:27 parec:
32 command: bin/client-wrapper usr/bin/parec28 command: bin/client-wrapper usr/bin/parec
33 plugs: [client, home, network]29 plugs: [playback, record, home, network]
34 # NOTE: This is deprecated with snapd 2.25 but needs to stay to
35 # guarantee all clients are updated correctly.
36 config:30 config:
37 command: bin/config31 command: bin/config
3832
33# For compatibility reasons, we will still offer the pulseaudio
34# slot, so older snaps can connect to it.
39slots:35slots:
40 service:36 service:
41 interface: pulseaudio37 interface: pulseaudio
4238
43plugs:39plugs:
44 client:40 playback:
45 interface: pulseaudio41 interface: audio-playback
42 record:
43 interface: audio-record
4644
47parts:45parts:
48 pulseaudio-common:46 pulseaudio-common:
@@ -143,7 +141,6 @@ parts:
143 - --disable-systemd-login141 - --disable-systemd-login
144 - --without-caps142 - --without-caps
145 - --disable-webrtc-aec143 - --disable-webrtc-aec
146 - --disable-dbus
147 - --disable-oss-output144 - --disable-oss-output
148 - --disable-oss-wrapper145 - --disable-oss-wrapper
149 - --disable-jack146 - --disable-jack

Subscribers

People subscribed via source and target branches